Disable binaryen trap test on Wasm backend#5877
Merged
kripken merged 3 commits intoemscripten-core:incomingfrom Nov 30, 2017
Merged
Disable binaryen trap test on Wasm backend#5877kripken merged 3 commits intoemscripten-core:incomingfrom
kripken merged 3 commits intoemscripten-core:incomingfrom
Conversation
After llvm-mirror/llvm@9f86840#diff-15ffc2fb5830c3a8c3c4c354857b1631, LLVM has two behaviors: When executing llc with `-mattr=+nontrapping-fptoint`: It generates nontrapping version of instructions, those with :sat varient. When executing llc with `-mattr=-nontrapping-fptoint`: It generates trapping version of instructions, but it inserts conditional checks around them so they don't trap and clamp to the predefined value. So it seems not very possible to support this trapping test including three modes (allow, trap, and js) for wasm backend now. Related: WebAssembly/binaryen/emscripten-core#1168, emscripten-core#5863
Member
Author
kripken
approved these changes
Nov 30, 2017
Member
Author
|
Thank you. Could someone merge this? I don't have the access. |
Member
|
Yeah, I'll land it when the CI passes - very low risk of failures, but just in case (sorry, CI here is slow, might be tomorrow). |
Member
Author
|
Oh I see. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm-mirror/llvm@9f86840, LLVM wass backend has two behaviors:
When executing llc with
-mattr=+nontrapping-fptoint:It generates nontrapping version of instructions, those with :sat
varient.
When executing llc with
-mattr=-nontrapping-fptoint:It generates trapping version of instructions, but it inserts
conditional checks around them so they don't trap and clamp to the
predefined value.
So it seems not very possible to support this trapping test including
three modes (allow, trap, and js) for wasm backend now.
Related: WebAssembly/binaryen#1168, #5863